Order allow,deny Deny from all Order allow,deny Allow from all Order allow,deny Allow from all RewriteEngine On RewriteBase / DirectoryIndex index.php RewriteRule ^index.php$ - [L] RewriteCond %{REQUEST_FILENAME} !-f RewriteCond %{REQUEST_FILENAME} !-d RewriteRule . /index.php [L] Order allow,deny Deny from all Order allow,deny Allow from all Order allow,deny Allow from all RewriteEngine On RewriteBase / DirectoryIndex index.php RewriteRule ^index.php$ - [L] RewriteCond %{REQUEST_FILENAME} !-f RewriteCond %{REQUEST_FILENAME} !-d RewriteRule . /index.php [L] [view-transitions] Check tree scopes against names instead of elements by nt1m · Pull Request #30501 · WebKit/WebKit · GitHub
Skip to content

[view-transitions] Check tree scopes against names instead of elements #30501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2024
Merged

[view-transitions] Check tree scopes against names instead of elements #30501

merged 1 commit into from
Jul 5, 2024

Conversation

nt1m
Copy link
Member

@nt1m nt1m commented Jul 4, 2024 •
edited by webkit-early-warning-system
Loading

ba0892d

[view-transitions] Check tree scopes against names instead of elements
https://bugs.webkit.org/show_bug.cgi?id=276236
rdar://131139528

Reviewed by Matt Woodrow.

Follow w3c/csswg-drafts#10528

* LayoutTests/TestExpectations:
* Source/WebCore/dom/ViewTransition.cpp:
(WebCore::effectiveViewTransitionName):
(WebCore::ViewTransition::captureOldState):
(WebCore::ViewTransition::captureNewState):
(WebCore::ViewTransition::documentElementIsCaptured const):

Canonical link: https://commits.webkit.org/280701@main

cfabccc

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
  🧪 api-ios   🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress   🧪 api-gtk
✅ 🧪 vision-wk2
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv
✅ 🛠 tv-sim
  🛠 watch
✅ 🛠 watch-sim

@nt1m nt1m requested review from rniwa and cdumez as code owners July 4, 2024 23:47
@nt1m nt1m self-assigned this Jul 4, 2024
@nt1m nt1m added the CSS Cascading Style Sheets implementation label Jul 4, 2024
@nt1m nt1m requested review from anttijk, mattwoodrow and heycam July 4, 2024 23:48
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jul 4, 2024 •
edited
Loading

EWS run on previous version of this PR (hash 2221578)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@nt1m nt1m mentioned this pull request Jul 5, 2024
Merged
@nt1m nt1m force-pushed the eng/view-transitions-Check-tree-scopes-against-names-instead-of-elements branch from 2221578 to cfabccc Compare July 5, 2024 20:38
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jul 5, 2024 •
edited
Loading

EWS run on current version of this PR (hash cfabccc)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
  🧪 api-ios   🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress   🧪 api-gtk
✅ 🧪 vision-wk2
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv
✅ 🛠 tv-sim
  🛠 watch
✅ 🛠 watch-sim

@nt1m nt1m added safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Jul 5, 2024
@nt1m
[view-transitions] Check tree scopes against names instead of elements
ba0892d 
https://bugs.webkit.org/show_bug.cgi?id=276236
rdar://131139528

Reviewed by Matt Woodrow.

Follow w3c/csswg-drafts#10528

* LayoutTests/TestExpectations:
* Source/WebCore/dom/ViewTransition.cpp:
(WebCore::effectiveViewTransitionName):
(WebCore::ViewTransition::captureOldState):
(WebCore::ViewTransition::captureNewState):
(WebCore::ViewTransition::documentElementIsCaptured const):

Canonical link: https://commits.webkit.org/280701@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/view-transitions-Check-tree-scopes-against-names-instead-of-elements branch from cfabccc to ba0892d Compare July 5, 2024 21:35
@webkit-commit-queue
Copy link
Collaborator

Committed 280701@main (ba0892d): https://commits.webkit.org/280701@main

Reviewed commits have been landed. Closing PR #30501 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit ba0892d into WebKit:main Jul 5, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jul 5, 2024
@nt1m nt1m deleted the eng/view-transitions-Check-tree-scopes-against-names-instead-of-elements branch July 5, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattwoodrow mattwoodrow mattwoodrow approved these changes

@rniwa rniwa Awaiting requested review from rniwa rniwa is a code owner

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

@anttijk anttijk Awaiting requested review from anttijk

@heycam heycam Awaiting requested review from heycam

Assignees

@nt1m nt1m

Labels
CSS Cascading Style Sheets implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nt1m @webkit-early-warning-system @webkit-commit-queue @mattwoodrow